Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix cmakelists of parallel backend example #23417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 11, 2023
Merged

fix cmakelists of parallel backend example #23417

merged 5 commits into from
Apr 11, 2023

Conversation

souch
Copy link
Contributor

@souch souch commented Mar 27, 2023 •
edited
Loading

closes #23376

@mshabunin
Copy link
Contributor

This file already have two different project calls, but only when TBB or OpenMP has been found. If you experience configuration error, it means that neither of these libraries have been found. Perhaps an additional check and an error message might be useful instead of third project call.

@asmorkalov asmorkalov requested a review from mshabunin April 2, 2023 11:32
@souch
Copy link
Contributor Author

souch commented Apr 4, 2023 •
edited
Loading

The cmake error actually comes from calling find_package(OpenMP) before any project call.

CMake Error at /usr/share/cmake-3.22/Modules/FindOpenMP.cmake:615 (message):
  FindOpenMP requires the C, CXX or Fortran languages to be enabled
Call Stack (most recent call first):
  CMakeLists.txt:8 (find_package)

I changed the pull request so that it just call project before find_package.
Thanks for taking your time for this minor problem.

@mshabunin
Copy link
Contributor

I suggest applying similar change to the TBB block for consistency.

@asmorkalov asmorkalov merged commit 88a7e8c into opencv:4.x Apr 11, 2023
@asmorkalov asmorkalov added this to the 4.8.0 milestone Apr 11, 2023
@asmorkalov asmorkalov mentioned this pull request May 31, 2023
Merged
thewoz pushed a commit to thewoz/opencv that referenced this pull request Jan 4, 2024
@souch @thewoz
Merge pull request opencv#23417 from souch:souch-fix-parallel-backend…
6648e62 
…-example

fix cmakelists of parallel backend example
closes opencv#23376
thewoz pushed a commit to thewoz/opencv that referenced this pull request May 29, 2024
@souch @thewoz
Merge pull request opencv#23417 from souch:souch-fix-parallel-backend…
6e55b3d 
…-example

fix cmakelists of parallel backend example
closes opencv#23376
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mshabunin mshabunin mshabunin approved these changes

Assignees

No one assigned

Labels

category: build/install category: samples

Projects

None yet

Milestone

4.8.0

Development

Successfully merging this pull request may close these issues.

fix cmakelists of parallel backend example

3 participants

@souch @mshabunin @asmorkalov