Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

dmatveev
Copy link
Contributor

@dmatveev dmatveev commented Apr 2, 2023

  • Point3f was added to type traits but was missing in the "own" package; fixed.

Note to test the build you'd need to get & build ADE first:

$ git clone https://github.com/opencv/ade.git
$ mkdir ade_BUILD
$ cd ade_BUILD
$ cmake ../ade -DCMAKE_INSTALL_PREFIX=install -DCMAKE_BUILD_TYPE=Release
$ make
$ make install

After that:

$ mkdir gapi_BUILD
$ cd gapi_BUILD
$ cmake /path/to/opencv/modules/gapi -Dade_DIR=/path/to/ade_BUILD/install/share/ade -DCMAKE_BUILD_TYPE=Release
$ make

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

- Point3f was added to type traits but was missing in the "own" package; fixed.
@dmatveev dmatveev added this to the 4.8.0 milestone Apr 2, 2023
@dmatveev dmatveev requested a review from TolyaTalamanov April 2, 2023 14:59
@asmorkalov asmorkalov self-requested a review April 3, 2023 10:53
@asmorkalov asmorkalov self-assigned this Apr 3, 2023
Copy link
Contributor

@asmorkalov asmorkalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Tested manually with Ubuntu 20.04

@asmorkalov asmorkalov merged commit 51f5ee6 into opencv:4.x Apr 3, 2023
@dmatveev
Copy link
Contributor Author

dmatveev commented Apr 4, 2023

Tested manually with Ubuntu 20.04

Thanks @asmorkalov ! probably we'd need to add a pipeline to Actions to test that automatically? Do you think it is feasible?

@asmorkalov asmorkalov mentioned this pull request May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants