Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

gottagofaster236
Copy link
Contributor

@gottagofaster236 gottagofaster236 commented Apr 7, 2023

This is a follow-up on #23460. Since OBS uses NV12 internally, it's better to capture in NV12 to avoid unnecessary conversions on the OBS side. This also removes the YUY2 implementation changes in #23460 that were specific to the OBS Virtual Camera.

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • The feature is well documented and sample code can be built with the project CMake

@gottagofaster236 gottagofaster236 force-pushed the use_nv12_for_obs_camera branch from 5c0def0 to d30830d Compare April 8, 2023 23:57
Copy link
Contributor

@opencv-alalek opencv-alalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

  • Validated with OBS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants