Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Charuco board into interactive calibration #23479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 5, 2023
Merged

Charuco board into interactive calibration #23479

merged 1 commit into from
May 5, 2023

Conversation

vovka643
Copy link
Contributor

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

asmorkalov
asmorkalov requested changes Apr 10, 2023
View reviewed changes
Copy link
Contributor

@asmorkalov asmorkalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also please tune interactive calibration tool tutorial to cover the options.

@asmorkalov asmorkalov self-assigned this Apr 10, 2023
@asmorkalov asmorkalov added this to the 4.8.0 milestone Apr 10, 2023
@asmorkalov
Copy link
Contributor

BTW Ci reports compiler warning:

 /home/ci/opencv/apps/interactive-calibration/frameProcessor.cpp:283:110: warning: enum constant in boolean context [-Wint-in-bool-context]

@asmorkalov
Copy link
Contributor

Discussed board size issue offline. Decided to remove +1 for charuco board size, but add note about the board size units. Chessboard and radon board size are defined in inner corners, all other boards - in elements (circles or squares).

asmorkalov
asmorkalov approved these changes May 4, 2023
View reviewed changes
Copy link
Contributor

@asmorkalov asmorkalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@asmorkalov asmorkalov merged commit f7bee78 into opencv:4.x May 5, 2023
@AleksandrPanov AleksandrPanov mentioned this pull request May 17, 2023
Closed
4 tasks
@asmorkalov asmorkalov mentioned this pull request May 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asmorkalov asmorkalov asmorkalov approved these changes

Assignees

@asmorkalov asmorkalov

Labels

category: apps OpenCV builtin tools category: objdetect

Projects

None yet

Milestone

4.8.0

Development

Successfully merging this pull request may close these issues.

2 participants

@vovka643 @asmorkalov