updated mac catalyst target to be compatible with latest xCode / macos #23514
Conversation
| sdk_path = check_output(["xcodebuild", "-version", "-sdk", "macosx", "Path"]).decode('utf-8').rstrip() | ||
| c_flags = [ | ||
| "-target %s-apple-ios13.0-macabi" % target[0], # e.g. x86_64-apple-ios13.2-macabi # -mmacosx-version-min=10.15 | ||
| "-target %s-apple-ios14.0-macabi" % target[0], # e.g. x86_64-apple-ios13.2-macabi # -mmacosx-version-min=10.15 |
There was a problem hiding this comment.
I think it should be conditional, depending on XCode and system version, because hardcoding breaks older configuration.
There was a problem hiding this comment.
Agree, I tried to detect somehow min iOS version for catalyst for installed Xcode, but without success. However, iOS 14 is 3 years old, so that it means that AFAIK you will have to use older than Xcode 11 to break compilation with this change (current Xcode is 14.3). I am not sure if it is even possible to upload build that is created in Xcode <12 to App Store.
From the other way, the original implementation fails on current Xcode 14.
I can make it backward compatible, however it would be better to make it forward compatible. Any idea? Next year, Apple probably drop catalyst iOS 14 compatibility (or not - who knows).
|
When can we expect code merge? |
Pull Request Readiness Checklist
This pull request fixes bug #23507.