Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Added test for LSTM without hidden state initialisation #23545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 27, 2023
Merged

Added test for LSTM without hidden state initialisation #23545

merged 1 commit into from
Apr 27, 2023

Conversation

Abdurrahheem
Copy link
Contributor

@Abdurrahheem Abdurrahheem commented Apr 25, 2023 •
edited by rogday
Loading

Added test for covering this PR #23475 fixing the issue #21118 where functionality for hidden states as inputs was supported
Test data lives here: #1062

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@Abdurrahheem
added test for lstm without hidden
3b1ee05 
states initialization
@Abdurrahheem Abdurrahheem mentioned this pull request Apr 25, 2023
Merged
@Abdurrahheem Abdurrahheem self-assigned this Apr 25, 2023
@rogday
Copy link
Member

rogday commented Apr 25, 2023

Is this related to #23475 ?

@asmorkalov
Copy link
Contributor

yes

@asmorkalov asmorkalov added the category: dnn (onnx) ONNX suport issues in DNN module label Apr 25, 2023
@asmorkalov asmorkalov added this to the 4.8.0 milestone Apr 25, 2023
@Abdurrahheem Abdurrahheem marked this pull request as ready for review April 25, 2023 14:26
@asmorkalov asmorkalov mentioned this pull request Apr 27, 2023
Closed
asmorkalov
asmorkalov approved these changes Apr 27, 2023
View reviewed changes
Copy link
Contributor

@asmorkalov asmorkalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@asmorkalov asmorkalov merged commit 6dbc5e0 into opencv:4.x Apr 27, 2023
@asmorkalov asmorkalov mentioned this pull request May 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asmorkalov asmorkalov asmorkalov approved these changes

@rogday rogday Awaiting requested review from rogday

Assignees

@Abdurrahheem Abdurrahheem

Labels

category: dnn (onnx) ONNX suport issues in DNN module category: dnn test

Projects

None yet

Milestone

4.8.0

Development

Successfully merging this pull request may close these issues.

4 participants

@Abdurrahheem @rogday @asmorkalov @opencv-alalek