Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

LaurentBerger
Copy link
Contributor

@LaurentBerger LaurentBerger commented Apr 28, 2023

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work issue why the doc disappeared for format #23553
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

mmmmmmmmmmmmmmmmmmmmmmmit message for your changes. Lines starting
@opencv-alalek opencv-alalek added bug category: documentation Documentation fix or update labels Apr 28, 2023
@opencv-alalek opencv-alalek linked an issue Apr 28, 2023 that may be closed by this pull request
@asmorkalov asmorkalov changed the title don't ignore format in doc don't ignore documentation for cv::format in doxygen Apr 28, 2023
@asmorkalov
Copy link
Contributor

@LaurentBerger Thanks a lot for the contribution. //! @cond IGNORED at line 64 should be moved inside of cv namespace definition. Otherwise format function is documented out of cv namespace.

@asmorkalov asmorkalov self-requested a review April 28, 2023 07:59
Copy link
Contributor

@asmorkalov asmorkalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@asmorkalov asmorkalov self-assigned this Apr 28, 2023
@asmorkalov asmorkalov merged commit 23b819e into opencv:4.x Apr 28, 2023
@LaurentBerger LaurentBerger deleted the doc_format branch May 17, 2023 14:18
@asmorkalov asmorkalov mentioned this pull request May 31, 2023
thewoz pushed a commit to thewoz/opencv that referenced this pull request Jan 4, 2024
don't ignore documentation for cv::format in doxygen opencv#23555 

Issue opencv#23553

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

- [x] I agree to contribute to the project under Apache 2 License.
- [x] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
- [x] The PR is proposed to the proper branch
- [x] There is a reference to the original bug report and related work issue
- [x] There is accuracy test, performance test and test data in opencv_extra repository, if applicable
      Patch to opencv_extra has the same branch name.
- [x] The feature is well documented and sample code can be built with the project CMake
thewoz pushed a commit to thewoz/opencv that referenced this pull request May 29, 2024
don't ignore documentation for cv::format in doxygen opencv#23555 

Issue opencv#23553

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

- [x] I agree to contribute to the project under Apache 2 License.
- [x] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
- [x] The PR is proposed to the proper branch
- [x] There is a reference to the original bug report and related work issue
- [x] There is accuracy test, performance test and test data in opencv_extra repository, if applicable
      Patch to opencv_extra has the same branch name.
- [x] The feature is well documented and sample code can be built with the project CMake
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug category: documentation Documentation fix or update

Projects

None yet

Development

Successfully merging this pull request may close these issues.

why the doc disappeared for format

3 participants