Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Use std::atomic<bool> as it's necessary for correct thread safety #23566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 16, 2023
Merged

Use std::atomic<bool> as it's necessary for correct thread safety #23566

merged 1 commit into from
May 16, 2023

Conversation

seanm
Copy link
Contributor

@seanm seanm commented May 1, 2023 •
edited by opencv-alalek
Loading

Now that C++11 is required, we can unconditionally use std::atomic in this case, which is more correct.

force_builders=Custom
build_image:Custom=centos:7
buildworker:Custom=linux-1

@seanm
Use std::atomic<bool> as it's necessary for correct thread safety
27e10ef 
Now that C++11 is required, we can unconditionally use std::atomic in this case, which is more correct.
@asmorkalov asmorkalov requested a review from opencv-alalek May 2, 2023 05:21
@seanm
Copy link
Contributor Author

seanm commented May 15, 2023

@asmorkalov @opencv-alalek friendly ping...

@opencv-alalek opencv-alalek added this to the 4.8.0 milestone May 16, 2023
opencv-alalek
opencv-alalek approved these changes May 16, 2023
View reviewed changes
Copy link
Contributor

@opencv-alalek opencv-alalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@opencv-alalek opencv-alalek self-assigned this May 16, 2023
@opencv-pushbot opencv-pushbot merged commit 04d71da into opencv:4.x May 16, 2023
@asmorkalov asmorkalov mentioned this pull request May 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@opencv-alalek opencv-alalek opencv-alalek approved these changes

Assignees

@opencv-alalek opencv-alalek

Labels

category: core

Projects

None yet

Milestone

4.8.0

Development

Successfully merging this pull request may close these issues.

4 participants

@seanm @opencv-alalek @opencv-pushbot @asmorkalov