Thanks to visit codestin.com
Credit goes to github.com

Skip to content

dnn: refactor reduce #23613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 17, 2023
Merged

dnn: refactor reduce #23613

merged 4 commits into from
May 17, 2023

Conversation

fengyuentau
Copy link
Member

Reasons of refactoring reduce layer:

  • Previous impl is not a single operation impl, leading to difficulties for other backend to support reduce layer.
  • [need to validate] Previous impl does not consider a case when reduced axes are symmetric.

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@fengyuentau fengyuentau requested review from rogday and zihaomu May 15, 2023 10:05
zihaomu
zihaomu approved these changes May 15, 2023
View reviewed changes
Copy link
Member

@zihaomu zihaomu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@zihaomu zihaomu added category: dnn (onnx) ONNX suport issues in DNN module optimization labels May 15, 2023
@fengyuentau
Copy link
Member Author

Some variables are removed as they are not needed with this patch, causing some alerts in default, but it should be fine.

@opencv-alalek opencv-alalek added this to the 4.8.0 milestone May 15, 2023
opencv-alalek
opencv-alalek reviewed May 16, 2023
View reviewed changes
@vpisarev vpisarev self-requested a review May 17, 2023 07:03
@vpisarev vpisarev merged commit eefee85 into opencv:4.x May 17, 2023
@asmorkalov asmorkalov mentioned this pull request Jul 4, 2023
Merged
@opencv-alalek opencv-alalek mentioned this pull request Aug 5, 2023
Merged
6 tasks
thewoz pushed a commit to thewoz/opencv that referenced this pull request Jan 4, 2024
@fengyuentau @thewoz
dnn: refactor reduce (opencv#23613)
cec787d 
* initial impl

* remove reduce in8; fix reduce importer

* fix bugs and add log sum exp

* remove unnecessary header and fix indentation
@fengyuentau fengyuentau mentioned this pull request Feb 21, 2024
Open
48 tasks
thewoz pushed a commit to thewoz/opencv that referenced this pull request May 29, 2024
@fengyuentau @thewoz
dnn: refactor reduce (opencv#23613)
f30d74c 
* initial impl

* remove reduce in8; fix reduce importer

* fix bugs and add log sum exp

* remove unnecessary header and fix indentation
@fengyuentau fengyuentau deleted the refactor_reduce branch June 28, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@opencv-alalek opencv-alalek opencv-alalek left review comments

@vpisarev vpisarev vpisarev approved these changes

@zihaomu zihaomu zihaomu approved these changes

@rogday rogday Awaiting requested review from rogday

Assignees

No one assigned

Labels

category: dnn (onnx) ONNX suport issues in DNN module category: dnn optimization

Projects

None yet

Milestone

4.8.0

Development

Successfully merging this pull request may close these issues.

4 participants

@fengyuentau @vpisarev @zihaomu @opencv-alalek