Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

TinyTinni
Copy link
Contributor

For dark Qt themes, it is hard to read the pixel color information on the bottom left, like the coordinates or RGB values. This PR proposes a way on how the dynamically sets the font colors based on the system's theme.
Original Example:

original

With patch:

image

For Windows, nothing is changed (tested on a windows 11 system), because the font color is #000000 when using the default Qt theme.

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@asmorkalov asmorkalov self-assigned this May 16, 2023
@asmorkalov asmorkalov self-requested a review May 16, 2023 06:14
@asmorkalov asmorkalov added this to the 4.8.0 milestone May 16, 2023
Copy link
Contributor

@asmorkalov asmorkalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the contribution! Tested manually with Ubuntu 18.04 and KDE. Works great!

@asmorkalov asmorkalov merged commit 0800574 into opencv:4.x May 16, 2023
@TinyTinni TinyTinni deleted the pixel-info-font-color branch May 16, 2023 17:54
@asmorkalov asmorkalov mentioned this pull request May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants