Thanks to visit codestin.com
Credit goes to github.com

Skip to content

DNN: Remove unnecessary flags for convolution #23625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 26, 2023
Merged

DNN: Remove unnecessary flags for convolution #23625

merged 1 commit into from
May 26, 2023

Conversation

zihaomu
Copy link
Member

@zihaomu zihaomu commented May 16, 2023

Since we have supported the Convolution 1D, 2D, and 3D, we can perform the Conv_Add trick for all types of Convolution.

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@opencv-alalek opencv-alalek added category: dnn cleanup Code cleanup (e.g, drop legacy C-API, legacy unmaintained code) labels May 16, 2023
@opencv-alalek opencv-alalek added this to the 4.8.0 milestone May 16, 2023
@asmorkalov asmorkalov requested a review from dkurt May 16, 2023 08:43
@vpisarev vpisarev self-requested a review May 19, 2023 08:16
@asmorkalov
Copy link
Contributor

@opencv-alalek Could you take a look and tune CI?

@asmorkalov asmorkalov requested review from opencv-alalek and removed request for vpisarev May 22, 2023 07:36
dkurt
dkurt approved these changes May 22, 2023
View reviewed changes
Copy link
Member

@dkurt dkurt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good, thanks!

@zihaomu
Copy link
Member Author

zihaomu commented May 25, 2023

Hi @opencv-alalek, the default CI failed because I removed the unused flag bool isConv2D = false;.

@vpisarev vpisarev self-requested a review May 26, 2023 07:56
@asmorkalov asmorkalov merged commit cf0ba03 into opencv:4.x May 26, 2023
@asmorkalov asmorkalov mentioned this pull request May 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vpisarev vpisarev vpisarev approved these changes

@dkurt dkurt dkurt approved these changes

@opencv-alalek opencv-alalek Awaiting requested review from opencv-alalek

Assignees

No one assigned

Labels

category: dnn cleanup Code cleanup (e.g, drop legacy C-API, legacy unmaintained code)

Projects

None yet

Milestone

4.8.0

Development

Successfully merging this pull request may close these issues.

5 participants

@zihaomu @asmorkalov @vpisarev @dkurt @opencv-alalek