Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Proposed solution for issue #23633 #23638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 18, 2023
Merged

Proposed solution for issue #23633 #23638

merged 1 commit into from
May 18, 2023

Conversation

soyszala
Copy link
Contributor

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
    https://github.com/opencv/opencv/issues/23633
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@asmorkalov asmorkalov requested a review from VadimLevin May 18, 2023 06:48
@asmorkalov asmorkalov added this to the 4.8.0 milestone May 18, 2023
VadimLevin
VadimLevin approved these changes May 18, 2023
View reviewed changes
Copy link
Contributor

@VadimLevin VadimLevin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the issue was caused by PyObject_SetAttrString -> PyObject_GenericSetAttr that under the hood calls Py_INCREF on provided value

@dkurt dkurt linked an issue May 18, 2023 that may be closed by this pull request
opencv-python Memory leak caused by failed cvtColor() calls #23633
Closed
4 tasks
@asmorkalov asmorkalov merged commit 435ccfd into opencv:4.x May 18, 2023
@opencv-alalek opencv-alalek added the backport is needed Label for maintainers. Authors of PR can ignore this label May 18, 2023
@asmorkalov asmorkalov mentioned this pull request May 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@VadimLevin VadimLevin VadimLevin approved these changes

Assignees

@VadimLevin VadimLevin

Labels

backport is needed Label for maintainers. Authors of PR can ignore this bug category: python bindings

Projects

None yet

Milestone

4.8.0

Development

Successfully merging this pull request may close these issues.

opencv-python Memory leak caused by failed cvtColor() calls

4 participants

@soyszala @VadimLevin @asmorkalov @opencv-alalek