Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[CI] : add the ci node of Vulkan #23641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 22, 2023
Merged

[CI] : add the ci node of Vulkan #23641

merged 1 commit into from
May 22, 2023

Conversation

zihaomu
Copy link
Member

@zihaomu zihaomu commented May 18, 2023

Merge after: opencv/ci-gha-workflow#95

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@zihaomu zihaomu added the need-ci-update CI or Infra update required to merge PR label May 18, 2023
@zihaomu zihaomu requested a review from asmorkalov May 18, 2023 08:31
asmorkalov
asmorkalov approved these changes May 19, 2023
View reviewed changes
Copy link
Contributor

@asmorkalov asmorkalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM, but lets' wait for the main part fixes in opencv/ci-gha-workflow#95

asmorkalov
asmorkalov approved these changes May 22, 2023
View reviewed changes
Copy link
Contributor

@asmorkalov asmorkalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@asmorkalov asmorkalov merged commit 2e9eb05 into opencv:4.x May 22, 2023
@asmorkalov asmorkalov self-assigned this May 22, 2023
@asmorkalov asmorkalov mentioned this pull request May 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asmorkalov asmorkalov asmorkalov approved these changes

Assignees

@asmorkalov asmorkalov

Labels

need-ci-update CI or Infra update required to merge PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@zihaomu @asmorkalov