Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Addition of normalize_axis to ONNXImporter::parseSqueeze #23707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 30, 2023
Merged

Addition of normalize_axis to ONNXImporter::parseSqueeze #23707

merged 1 commit into from
May 30, 2023

Conversation

oHotel
Copy link
Contributor

@oHotel oHotel commented May 30, 2023

Addition of normalize_axis to ONNXImporter::parseSqueeze to prevent a bug when the attribute axes contains negative values. Negative values are part of the ONNX standard: https://github.com/onnx/onnx/blob/main/docs/Changelog.md#Squeeze-11

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@oHotel
Addition of normalize_axis to ONNXImporter::parseSqueeze to support n…
0442c6f 
…egative values for the axes attribut.

Negative values are part of the ONNX optset>=11.

Signed-off-by: Olivier Hotel <[email protected]>
dkurt
dkurt approved these changes May 30, 2023
View reviewed changes
Copy link
Member

@dkurt dkurt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! LGTM

@asmorkalov asmorkalov added the category: dnn (onnx) ONNX suport issues in DNN module label May 30, 2023
@asmorkalov asmorkalov added this to the 4.8.0 milestone May 30, 2023
@asmorkalov asmorkalov merged commit c55aee1 into opencv:4.x May 30, 2023
@asmorkalov asmorkalov mentioned this pull request May 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dkurt dkurt dkurt approved these changes

Assignees

No one assigned

Labels

category: dnn (onnx) ONNX suport issues in DNN module

Projects

None yet

Milestone

4.8.0

Development

Successfully merging this pull request may close these issues.

3 participants

@oHotel @dkurt @asmorkalov