Fix compiler warnings for GCC 11-12 and Clang 13 #23938
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asmorkalov
approved these changes
Jul 7, 2023
modules/core/test/test_mat.cpp
Outdated
| #include "opencv2/core/eigen.hpp" | ||
| #endif | ||
|
|
||
| #ifdef CV_CXX11 |
Contributor
There was a problem hiding this comment.
We use C++11 by default. Why do you need the check?
Contributor
Author
There was a problem hiding this comment.
There is test below range_checking which uses GpuMat and is guarded by #ifdef CV_CXX11, so I added the same guard for the header. Probably both ifdefs should be removed if we choose to merge #23736 .
Contributor
There was a problem hiding this comment.
I propose to remove both CV_CXX11 checks as not relevant any more.
496b963 to
09944a8
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #22218
Note: patched gtest to avoid some warnings, the modification should not seriously interfere with future upgrades, even if this patch will be overwritten it won't be a serious problem.