Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Revert PR 24186 as it forces skipping tests #24223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 5, 2023
Merged

Revert PR 24186 as it forces skipping tests #24223

merged 1 commit into from
Sep 5, 2023

Conversation

@asmorkalov
Copy link
Contributor

@asmorkalov asmorkalov commented Sep 5, 2023 •
edited
Loading

Reverts #24186

Current test skipping issue:

./bin/opencv_test_dnn --gtest_filter=Test_Caffe_layers*
...
[       OK ] Test_Caffe_layers.DeConvolution/3 (3 ms)
[ RUN      ] Test_Caffe_layers.InnerProduct/0, where GetParam() = NGRAPH/CPU
[       OK ] Test_Caffe_layers.InnerProduct/0 (8 ms)
[ RUN      ] Test_Caffe_layers.InnerProduct/1, where GetParam() = OCV/OCL
[       OK ] Test_Caffe_layers.InnerProduct/1 (4 ms)
[ RUN      ] Test_Caffe_layers.InnerProduct/2, where GetParam() = OCV/OCL_FP16
[     SKIP ] Test with tag 'dnn_skip_ocl_fp16' is skipped ('dnn_skip_ocl_fp16' is in skip list)
[       OK ] Test_Caffe_layers.InnerProduct/2 (0 ms)
[ RUN      ] Test_Caffe_layers.InnerProduct/3, where GetParam() = OCV/CPU
[     SKIP ] 
[       OK ] Test_Caffe_layers.InnerProduct/3 (0 ms)
[ RUN      ] Test_Caffe_layers.Pooling_max/0, where GetParam() = NGRAPH/CPU
[     SKIP ] 
[       OK ] Test_Caffe_layers.Pooling_max/0 (0 ms)
[ RUN      ] Test_Caffe_layers.Pooling_max/1, where GetParam() = OCV/OCL
[     SKIP ] 
[       OK ] Test_Caffe_layers.Pooling_max/1 (0 ms)
[ RUN      ] Test_Caffe_layers.Pooling_max/2, where GetParam() = OCV/OCL_FP16
[     SKIP ] 
[       OK ] Test_Caffe_layers.Pooling_max/2 (0 ms)
[ RUN      ] Test_Caffe_layers.Pooling_max/3, where GetParam() = OCV/CPU
[     SKIP ] 
[       OK ] Test_Caffe_layers.Pooling_max/3 (0 ms)

All further tests are skipped.

More focused test invocation works well:

./bin/opencv_test_dnn --gtest_filter=Test_Caffe_layers.Pooling_max*
...
[ RUN      ] Test_Caffe_layers.Pooling_max/0, where GetParam() = NGRAPH/CPU
[       OK ] Test_Caffe_layers.Pooling_max/0 (23 ms)
[ RUN      ] Test_Caffe_layers.Pooling_max/1, where GetParam() = OCV/OCL
[       OK ] Test_Caffe_layers.Pooling_max/1 (4 ms)
[ RUN      ] Test_Caffe_layers.Pooling_max/2, where GetParam() = OCV/OCL_FP16
[       OK ] Test_Caffe_layers.Pooling_max/2 (2 ms)
[ RUN      ] Test_Caffe_layers.Pooling_max/3, where GetParam() = OCV/CPU
[       OK ] Test_Caffe_layers.Pooling_max/3 (1 ms)
[----------] 4 tests from Test_Caffe_layers (30 ms total)

[----------] Global test environment tear-down
[==========] 4 tests from 1 test case ran. (30 ms total)
[  PASSED  ] 4 tests.

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@asmorkalov asmorkalov requested a review from dkurt September 5, 2023 11:39
@asmorkalov asmorkalov added this to the 4.9.0 milestone Sep 5, 2023
@asmorkalov asmorkalov changed the title Revert PR 24186 as it force skip tests Revert PR 24186 as it forces skipping tests Sep 5, 2023
@dkurt dkurt mentioned this pull request Sep 5, 2023
Merged
6 tasks
@asmorkalov asmorkalov merged commit af9be78 into opencv:4.x Sep 5, 2023
@dkurt dkurt mentioned this pull request Sep 9, 2023
Merged
6 tasks
@asmorkalov asmorkalov mentioned this pull request Sep 11, 2023
Merged
asmorkalov pushed a commit that referenced this pull request Sep 18, 2023
@dkurt
Merge pull request #24250 from dkurt:ts_fixture_constructor_skip_2
6bc369f 
Skip test on SkipTestException at fixture's constructor (version 2) #24250

### Pull Request Readiness Checklist

Another version of #24186 (reverted by #24223). Current implementation cannot handle skip exception at `static void SetUpTestCase` but works on `virtual void SetUp`.

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

- [x] I agree to contribute to the project under Apache 2 License.
- [x] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
- [x] The PR is proposed to the proper branch
- [x] There is a reference to the original bug report and related work
- [x] There is accuracy test, performance test and test data in opencv_extra repository, if applicable
      Patch to opencv_extra has the same branch name.
- [x] The feature is well documented and sample code can be built with the project CMake
thewoz pushed a commit to thewoz/opencv that referenced this pull request Jan 4, 2024
@dkurt @thewoz
Merge pull request opencv#24250 from dkurt:ts_fixture_constructor_skip_2
13ab4c7 
Skip test on SkipTestException at fixture's constructor (version 2) opencv#24250

### Pull Request Readiness Checklist

Another version of opencv#24186 (reverted by opencv#24223). Current implementation cannot handle skip exception at `static void SetUpTestCase` but works on `virtual void SetUp`.

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

- [x] I agree to contribute to the project under Apache 2 License.
- [x] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
- [x] The PR is proposed to the proper branch
- [x] There is a reference to the original bug report and related work
- [x] There is accuracy test, performance test and test data in opencv_extra repository, if applicable
      Patch to opencv_extra has the same branch name.
- [x] The feature is well documented and sample code can be built with the project CMake
thewoz pushed a commit to thewoz/opencv that referenced this pull request May 29, 2024
@dkurt @thewoz
Merge pull request opencv#24250 from dkurt:ts_fixture_constructor_skip_2
cacf890 
Skip test on SkipTestException at fixture's constructor (version 2) opencv#24250

### Pull Request Readiness Checklist

Another version of opencv#24186 (reverted by opencv#24223). Current implementation cannot handle skip exception at `static void SetUpTestCase` but works on `virtual void SetUp`.

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

- [x] I agree to contribute to the project under Apache 2 License.
- [x] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
- [x] The PR is proposed to the proper branch
- [x] There is a reference to the original bug report and related work
- [x] There is accuracy test, performance test and test data in opencv_extra repository, if applicable
      Patch to opencv_extra has the same branch name.
- [x] The feature is well documented and sample code can be built with the project CMake
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dkurt dkurt dkurt approved these changes

Assignees

@dkurt dkurt

Labels

bug test

Projects

None yet

Milestone

4.9.0

Development

Successfully merging this pull request may close these issues.

2 participants

@asmorkalov @dkurt