Thanks to visit codestin.com
Credit goes to github.com

Skip to content

yolox detector #24267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 10 commits into from
Closed

yolox detector #24267

wants to merge 10 commits into from

Conversation

@LaurentBerger
Copy link
Contributor

@LaurentBerger LaurentBerger commented Sep 13, 2023

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work yolox in c++ opencv_zoo#177 (review)
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • [] The feature is well documented and sample code can be built with the project CMake

@LaurentBerger LaurentBerger marked this pull request as draft September 13, 2023 20:20
@fengyuentau fengyuentau self-assigned this Oct 20, 2023
@fengyuentau fengyuentau self-requested a review October 20, 2023 15:30
@LaurentBerger
Copy link
Contributor Author

LaurentBerger commented Nov 4, 2023

How can I write test in buildbot without model @fengyuentau ?

@fengyuentau
Copy link
Member

fengyuentau commented Nov 5, 2023

You need to submit a PR to https://github.com/opencv/opencv_extra adding an item in models in https://github.com/opencv/opencv_extra/blob/4.x/testdata/dnn/download_models.py. Note that a same branch name is required (yoloxdectector in this case).

Also note that YOLOX has been added:

https://github.com/opencv/opencv_extra/blob/7d91e2cd6ceee3d3ee3dbfed95189d68eed42318/testdata/dnn/download_models.py#L1011-L1015C34

So taking test_face.cpp as an example, you need to create a dedicated test file for your API, then find the model via:

    std::string model = findDataFile("dnn/yolox_s.onnx", false);

@LaurentBerger LaurentBerger mentioned this pull request Dec 12, 2023
Closed
10 tasks
@LaurentBerger LaurentBerger marked this pull request as ready for review December 13, 2023 07:43
@LaurentBerger
Copy link
Contributor Author

LaurentBerger commented Dec 13, 2023

This PR it's a waste of time

@LaurentBerger LaurentBerger mentioned this pull request Dec 16, 2023
Merged
6 tasks
@LaurentBerger LaurentBerger deleted the yoloxdectector branch May 15, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fengyuentau fengyuentau Awaiting requested review from fengyuentau

Assignees

@fengyuentau fengyuentau

Labels

category: dnn category: objdetect feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@LaurentBerger @fengyuentau @asmorkalov