Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Removed invalid reference usage in charuco detector #24354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 3, 2023
Merged

Removed invalid reference usage in charuco detector #24354

merged 1 commit into from
Oct 3, 2023

Conversation

@asmorkalov
Copy link
Contributor

@asmorkalov asmorkalov commented Oct 3, 2023 •
edited
Loading

Address 60ae973#r127863372

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@asmorkalov asmorkalov added this to the 4.9.0 milestone Oct 3, 2023
@asmorkalov
Copy link
Contributor Author

asmorkalov commented Oct 3, 2023

/cc @vrabaud

vrabaud
vrabaud reviewed Oct 3, 2023
View reviewed changes
modules/objdetect/src/aruco/charuco_detector.cpp
Mat mIds = markerIds.getMat();
Mat chCorners = charucoCorners.getMat();
Mat chIds = charucoIds.getMat();
const vector<int>& boardIds = board.getIds();
Copy link
Contributor

@vrabaud vrabaud Oct 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getIds() returns a const vector<int>& so this is fine

vrabaud
vrabaud reviewed Oct 3, 2023
View reviewed changes
vrabaud
vrabaud requested changes Oct 3, 2023
View reviewed changes
Copy link
Contributor

@vrabaud vrabaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also fix the nearestMarkerIdx reference.

vrabaud
vrabaud reviewed Oct 3, 2023
View reviewed changes
AleksandrPanov
AleksandrPanov approved these changes Oct 3, 2023
View reviewed changes
Copy link
Contributor

@AleksandrPanov AleksandrPanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@asmorkalov
Copy link
Contributor Author

asmorkalov commented Oct 3, 2023

@vrabaud please take a look again.

vrabaud
vrabaud approved these changes Oct 3, 2023
View reviewed changes
Copy link
Contributor

@vrabaud vrabaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will the API be changed for getNearestMarkerIdx and such at some point to avoid a vector copy? Otherwise, this PR is fine.

@asmorkalov asmorkalov merged commit 6bcf3d4 into opencv:4.x Oct 3, 2023
@asmorkalov asmorkalov mentioned this pull request Oct 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vrabaud vrabaud vrabaud approved these changes

@AleksandrPanov AleksandrPanov AleksandrPanov approved these changes

Assignees

@vrabaud vrabaud

Labels

bug category: objdetect

Projects

None yet

Milestone

4.9.0

Development

Successfully merging this pull request may close these issues.

4 participants

@asmorkalov @vrabaud @AleksandrPanov @opencv-alalek