-
-
Notifications
You must be signed in to change notification settings - Fork 56.4k
add imread #24415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add imread #24415
Conversation
|
First, I was confused why there is a need to have |
|
Hi @dkurt thank you very much |
|
@thewoz, you may refer to current imread by |
|
Hello everyone, |
|
I hope I understood what you meant |
opencv-alalek
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to add Python tests (modules/imgproc/misc/python/test/test_imread.py).
See https://github.com/opencv/opencv/blob/4.x/modules/dnn/misc/python/test/test_dnn.py as reference.
Run Python test from build directory:
OPENCV_PYTHON_DEBUG=1 OPENCV_PYTEST_FILTER=test_imread* ./setup_vars.sh python3 ${OPENCV_SRC_DIR}/modules/python/test/test.py -v --repo ${OPENCV_SRC_DIR}
|
I tried to write the test in python |
|
It remains to check the python test and what name to give to the function. |
Add imread opencv#24415 ### Pull Request Readiness Checklist See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request - [X] I agree to contribute to the project under Apache 2 License. - [X] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV - [X] The PR is proposed to the proper branch - [ ] There is a reference to the original bug report and related work - [ ] There is accuracy test, performance test and test data in opencv_extra repository, if applicable Patch to opencv_extra has the same branch name. - [x] The feature is well documented and sample code can be built with the project CMake Hello everyone, I created this new version of the imread function and I think it can be very useful in several cases. It is actually passed to it object on which you want to upload the image. The advantages can be different like in case one needs to open several large images all the same in sequence. one can use the same pointer and the system would not allocate memory each time.
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.
Hello everyone,
I created this new version of the imread function and I think it can be very useful in several cases.
It is actually passed to it object on which you want to upload the image.
The advantages can be different like in case one needs to open several large images all the same in sequence.
one can use the same pointer and the system would not allocate memory each time