Fix out of image corners in cv::cornerSubPix #24527
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
opencv-alalek
left a comment
There was a problem hiding this comment.
Thank you for the contribution!
Could you please add a simple test case with reproducer?
(see TEST(Imgproc_MatchTemplate, bug_9597) how to define image data (we probably don't need full image))
modules/imgproc/src/cornersubpix.cpp
Outdated
| // if new point is too far from initial, it means poor convergence. | ||
| // leave initial point as the result | ||
| if( fabs( cI.x - cT.x ) > win.width || fabs( cI.y - cT.y ) > win.height ) | ||
| if( cI.x < 0 || cI.x >= src.cols || cI.y < 0 || cI.y >= src.rows || |
Contributor
There was a problem hiding this comment.
Possible alternative:
lines 143 - 145:
if (Rect(0, 0, src.cols, src.rows).contains(cI2))
{
cI = cI2;
}
else
{
break;
}
Also it makes sense to perform input validation right after the line 98
CV_Assert(Rect(0, 0, src.cols, src.rows).contains(cT));
Contributor
|
@opencv-alalek The PR looks good for me. Could you take a look again. |
4 tasks
IskXCr
pushed a commit
to Haosonn/opencv
that referenced
this pull request
Dec 20, 2023
…orners-in-cv-cornersubpix Fix out of image corners in cv::cornerSubPix opencv#24527 ### Pull Request Readiness Checklist See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request - [x] I agree to contribute to the project under Apache 2 License. - [x] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV - [x] The PR is proposed to the proper branch - [ ] There is a reference to the original bug report and related work - [ ] There is accuracy test, performance test and test data in opencv_extra repository, if applicable Patch to opencv_extra has the same branch name. - [ ] The feature is well documented and sample code can be built with the project CMake
Merged
thewoz
pushed a commit
to thewoz/opencv
that referenced
this pull request
May 29, 2024
…orners-in-cv-cornersubpix Fix out of image corners in cv::cornerSubPix opencv#24527 ### Pull Request Readiness Checklist See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request - [x] I agree to contribute to the project under Apache 2 License. - [x] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV - [x] The PR is proposed to the proper branch - [ ] There is a reference to the original bug report and related work - [ ] There is accuracy test, performance test and test data in opencv_extra repository, if applicable Patch to opencv_extra has the same branch name. - [ ] The feature is well documented and sample code can be built with the project CMake
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.