Thanks to visit codestin.com
Credit goes to github.com

Skip to content

QR codes Structured Append decoding mode #24548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 1, 2024
Merged

QR codes Structured Append decoding mode #24548

merged 5 commits into from
Feb 1, 2024
+103 −25

Conversation

@dkurt
Copy link
Member

@dkurt dkurt commented Nov 15, 2023 •
edited
Loading

Pull Request Readiness Checklist

resolves #23245

Merge after #24299

Current proposal is to use detectAndDecodeMulti or decodeMulti for structured append mode decoding. 0-th QR code in a sequence gets a full message while the rest of codes will correspond to empty strings.

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@dkurt dkurt force-pushed the qrcode_struct_append_decode branch from fa9d88f to c5131b8 Compare November 27, 2023 16:40
@asmorkalov asmorkalov added this to the 4.10.0 milestone Dec 20, 2023
@dkurt dkurt force-pushed the qrcode_struct_append_decode branch from c5131b8 to 8c4ccf2 Compare January 26, 2024 11:48
@dkurt dkurt linked an issue Jan 29, 2024 that may be closed by this pull request
Problem with QRCodeEncoder#encodeStructuredAppend function #24851
Closed
4 tasks
@dkurt dkurt marked this pull request as ready for review January 29, 2024 08:15
@dkurt dkurt mentioned this pull request Jan 29, 2024
Closed
4 tasks
@dkurt dkurt requested a review from AleksandrPanov January 29, 2024 08:16
asmorkalov
asmorkalov approved these changes Feb 1, 2024
View reviewed changes
Copy link
Contributor

@asmorkalov asmorkalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 No regression in benchmark.

@asmorkalov asmorkalov self-assigned this Feb 1, 2024
@asmorkalov asmorkalov merged commit fc32903 into opencv:4.x Feb 1, 2024
@dkurt dkurt deleted the qrcode_struct_append_decode branch February 1, 2024 14:23
This was referenced Feb 3, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asmorkalov asmorkalov asmorkalov approved these changes

@AleksandrPanov AleksandrPanov Awaiting requested review from AleksandrPanov

Assignees

@asmorkalov asmorkalov

Labels

category: objdetect feature

Projects

None yet

Milestone

4.10.0

Development

Successfully merging this pull request may close these issues.

Problem with QRCodeEncoder#encodeStructuredAppend function Structured Append mode support in QR code decoder

2 participants

@dkurt @asmorkalov