Thanks to visit codestin.com
Credit goes to github.com

Skip to content

dnn onnx: add mod #24765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Jan 9, 2024
Merged

dnn onnx: add mod #24765

merged 12 commits into from
Jan 9, 2024

Conversation

@fengyuentau
Copy link
Member

@fengyuentau fengyuentau commented Dec 25, 2023 •
edited by asmorkalov
Loading

Resolves #23174

TODO:

  • enable some conformance tests
  • add backends
    • CANN
    • OpenVINO
    • CUDA

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@fengyuentau fengyuentau added feature category: dnn category: dnn (onnx) ONNX suport issues in DNN module labels Dec 25, 2023
@fengyuentau fengyuentau added this to the 4.10.0 milestone Dec 25, 2023
@fengyuentau fengyuentau marked this pull request as ready for review December 26, 2023 10:30
@fengyuentau fengyuentau requested a review from dkurt December 26, 2023 10:30
dkurt
dkurt reviewed Dec 26, 2023
View reviewed changes
modules/dnn/src/onnx/onnx_importer.cpp Outdated
layerParams.type = "NaryEltwise";
layerParams.set("operation", toLowerCase(node_proto.op_type()));
if (node_proto.op_type() == "Mod") {
if (layerParams.has("fmod") && layerParams.get<int>("fmod") == 1) {
Copy link
Member

@dkurt dkurt Dec 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if (layerParams.has("fmod") && layerParams.get<int>("fmod") == 1) {
if (layerParams.get<int>("fmod", 0)) {

Copy link
Member Author

@fengyuentau fengyuentau Dec 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

dkurt
dkurt reviewed Dec 26, 2023
View reviewed changes
@asmorkalov
Copy link
Contributor

asmorkalov commented Jan 6, 2024

cc @LaurentBerger

@asmorkalov asmorkalov merged commit c955564 into opencv:4.x Jan 9, 2024
@fengyuentau fengyuentau deleted the mod_operator branch January 9, 2024 16:03
This was referenced Jan 19, 2024
Merged
Merged
@fengyuentau fengyuentau mentioned this pull request Feb 21, 2024
Open
48 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dkurt dkurt dkurt approved these changes

Assignees

@dkurt dkurt

Labels

category: dnn (onnx) ONNX suport issues in DNN module category: dnn feature

Projects

None yet

Milestone

4.10.0

3 participants

@fengyuentau @asmorkalov @dkurt