Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Use AVX2 overload instread on AVX in AVX2 scope #24858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 16, 2024
Merged

Use AVX2 overload instread on AVX in AVX2 scope #24858

merged 1 commit into from
Jan 16, 2024

Conversation

@Dhanwanth1803
Copy link
Contributor

@Dhanwanth1803 Dhanwanth1803 commented Jan 13, 2024 •
edited by asmorkalov
Loading

winofunc_AtXA_8x8_f32() needs function call in both AVX and in AVX2. Prior to this change the function was called under opt_AVX , now its called under opt_AVX2.

Fixes #24677

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work

@fengyuentau
Copy link
Member

fengyuentau commented Jan 14, 2024

Relates #24677

@fengyuentau fengyuentau requested a review from zihaomu January 14, 2024 05:54
@fengyuentau
Copy link
Member

fengyuentau commented Jan 14, 2024

@zihaomu Could you take a look at this?

@Dhanwanth1803
Copy link
Contributor Author

Dhanwanth1803 commented Jan 14, 2024

@zihaomu Could you take a look at this?

Thank you @fengyuentau . I think as the transform functions are defined in the same .cpp they can be called in both AVX and AVX2.

zihaomu
zihaomu approved these changes Jan 14, 2024
View reviewed changes
Copy link
Member

@zihaomu zihaomu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! LGTM 👍

@fengyuentau fengyuentau added this to the 4.10.0 milestone Jan 15, 2024
@asmorkalov
Copy link
Contributor

asmorkalov commented Jan 15, 2024

Request for comments. @dkurt @asmorkalov

@asmorkalov asmorkalov changed the title Fixes #24677 Use AVX2 overload instread on AVX in AVX2 scope Jan 15, 2024
@Dhanwanth1803
Copy link
Contributor Author

Dhanwanth1803 commented Jan 16, 2024

Request for comments. @dkurt @asmorkalov

@asmorkalov Sir, can you look at this.

asmorkalov
asmorkalov approved these changes Jan 16, 2024
View reviewed changes
Copy link
Contributor

@asmorkalov asmorkalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@asmorkalov asmorkalov merged commit 68dc02e into opencv:4.x Jan 16, 2024
@asmorkalov asmorkalov mentioned this pull request Jan 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asmorkalov asmorkalov asmorkalov approved these changes

@zihaomu zihaomu zihaomu approved these changes

@dkurt dkurt dkurt approved these changes

Assignees

No one assigned

Labels

bug category: dnn optimization

Projects

None yet

Milestone

4.10.0

Development

Successfully merging this pull request may close these issues.

In CV_TRY_AVX2 scope, AVX implementation was called

6 participants

@Dhanwanth1803 @fengyuentau @asmorkalov @zihaomu @dkurt @opencv-alalek