Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@zzuliys
Copy link
Contributor

@zzuliys zzuliys commented Jan 17, 2024

note:
1.Gemini2 and Gemini2L must use the latest firmware -- https://github.com/orbbec/OrbbecFirmware;
2.Administrator privileges are necessary to run on MacOS.

@fengyuentau
Copy link
Member

The only concern on my side is the sdk is needed if using the orbbec cameras on macOS. In this case how do we distribute prebuilt packages with this feature enable?

@fengyuentau
Copy link
Member

Reminder of CI complains:

# Doc
modules/videoio/CMakeLists.txt:240: trailing whitespace.
+    list(APPEND videoio_srcs 

# Build warnings
C:\build\precommit_windows64\4.x\opencv\modules\videoio\src\cap_obsensor\obsensor_uvc_stream_channel.cpp(320): warning C4305: '=': truncation from 'double' to 'float' [C:\build\precommit_windows64\build\modules\videoio\opencv_videoio.vcxproj]
C:\build\precommit_windows64\4.x\opencv\modules\videoio\src\cap_obsensor\obsensor_uvc_stream_channel.cpp(323): warning C4305: '=': truncation from 'double' to 'float' [C:\build\precommit_windows64\build\modules\videoio\opencv_videoio.vcxproj]

@kaingwade
Copy link
Contributor

Orbbec UVC cameras now works on MacOS.
Screenshot 2024-01-29 at 17 04 36

But there is the concern as @fengyuentau mentioned earlier:

The only concern on my side is the sdk is needed if using the orbbec cameras on macOS. In this case how do we distribute prebuilt packages with this feature enable?

@zzuliys
Copy link
Contributor Author

zzuliys commented Jan 29, 2024

Orbbec UVC cameras now works on MacOS. Screenshot 2024-01-29 at 17 04 36

But there is the concern as @fengyuentau mentioned earlier:

The only concern on my side is the sdk is needed if using the orbbec cameras on macOS. In this case how do we distribute prebuilt packages with this feature enable?

I'm sorry to inform you that currently, on MacOS, the Orbbec camera can only be implemented using this method.

Copy link
Member

@fengyuentau fengyuentau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I propose to merge it for now and there should be a subsequent PR providing another build option which detects and uses the pre-installed libOrbbec instead of downloading it every time.

@kaingwade
Copy link
Contributor

@asmorkalov Can the PR be merged as it is for now

@zzuliys
Copy link
Contributor Author

zzuliys commented Mar 25, 2024

@asmorkalov I see that you haven't raised any new questions for a long time, and all the issues you previously raised have been resolved. We hope the code can be merged as soon as possible. Thank you.

@asmorkalov
Copy link
Contributor

Looks good for me in general, besides minor remarks. CMake option to point external Orbbec SDK is required, but it could be done in dedicated PR as proposed.

@zzuliys
Copy link
Contributor Author

zzuliys commented Mar 28, 2024

@asmorkalov All the issues you have reported have been resolved

Copy link
Contributor

@asmorkalov asmorkalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@asmorkalov
Copy link
Contributor

@opencv-alalek Could you take a look?

@asmorkalov asmorkalov merged commit 2b9d1a2 into opencv:4.x Mar 29, 2024
@asmorkalov asmorkalov self-assigned this Mar 29, 2024
@asmorkalov asmorkalov added this to the 4.10.0 milestone Mar 29, 2024
@akretz akretz mentioned this pull request Mar 29, 2024
4 tasks
@opencv-alalek
Copy link
Contributor

@zzuliys Please take a look on #25298

@zzuliys
Copy link
Contributor Author

zzuliys commented Apr 1, 2024

@zzuliys Please take a look on #25298

https://github.com/opencv/opencv/pull/25301/files Sorry for my negligence. I have fixed this issue and you can test it out

@asmorkalov asmorkalov mentioned this pull request Apr 1, 2024
klatism pushed a commit to klatism/opencv that referenced this pull request May 17, 2024
Orbbec Camera supports MacOS,Gemini2 and Gemini2L support Y16 format opencv#24877

note:
1.Gemini2 and Gemini2L must use the latest firmware -- https://github.com/orbbec/OrbbecFirmware;
2.Administrator privileges are necessary to run on MacOS.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants