Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Draft: core: Extend norm() function for u64/s64/u32 #24888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Draft: core: Extend norm() function for u64/s64/u32 #24888

wants to merge 2 commits into from

Conversation

@Kumataro
Copy link
Contributor

@Kumataro Kumataro commented Jan 19, 2024

Extend norm() function to support u64/s64/u32.
This patch is not included HAL support.

Close #24887

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@Kumataro Kumataro changed the title core: support norm() function for u64/s64/u32 core: Extend norm() function for u64/s64/u32 Jan 19, 2024
@asmorkalov asmorkalov requested a review from vpisarev January 19, 2024 10:28
@opencv-alalek opencv-alalek added this to the 5.0 milestone Jan 24, 2024
@vpisarev
Copy link
Contributor

vpisarev commented Jan 29, 2024

please, wait for my bigger patch that I'm working on, don't merge this one yet

@Kumataro Kumataro changed the title core: Extend norm() function for u64/s64/u32 Draft: core: Extend norm() function for u64/s64/u32 Jan 29, 2024
@asmorkalov
Copy link
Contributor

asmorkalov commented Feb 12, 2024

@Kumataro could you rebase a fix conflicts?

@Kumataro
Copy link
Contributor Author

Kumataro commented Feb 12, 2024 •
edited
Loading

Thank you very much for your response!
I think this pull request is not need to merge, it should be closed.
Because almost what I want to fix has been contained in #24962 ( by different method, so I think it is hard to rebase it).

Only 1 additional change is needed, however I think it is better to create independent issue.
(Maybe it can cause out-of-boundary memory access.)

opencv/modules/ts/src/ts_func.cpp

Lines 11 to 15 in 1d18aba

const char* getTypeName( int type )
{
static const char* type_names[] = { "8u", "8s", "16u", "16s", "32s", "32f", "64f", "ptr" };
return type_names[CV_MAT_DEPTH(type)];
}

@Kumataro
Copy link
Contributor Author

Kumataro commented Feb 12, 2024

I created issue( #24991 ) and pull-request( #24992 ).

@Kumataro
Copy link
Contributor Author

Kumataro commented Feb 12, 2024

All are merged, so I will close this issue. Thank you very much!!

@Kumataro Kumataro closed this Feb 12, 2024
@opencv-alalek opencv-alalek removed this from the 5.0 milestone Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vpisarev vpisarev Awaiting requested review from vpisarev

Assignees

No one assigned

Labels

category: core feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Kumataro @vpisarev @asmorkalov @opencv-alalek