Modified Java tests to run on Android #24910
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asmorkalov
reviewed
Jan 25, 2024
asmorkalov
reviewed
Jan 29, 2024
modules/java/test/android_test/src/org/opencv/test/OpenCVTestRunner.java
Outdated
Show resolved
Hide resolved
26b2ba5 to
89ff186
Compare
asmorkalov
reviewed
Jan 30, 2024
Contributor
|
Please remove gradlew and gradlew.bat with related files as you use |
92f8c60 to
058e977
Compare
1ba6adc to
b945076
Compare
| minSdkVersion @ANDROID_MIN_SDK_VERSION@ | ||
| targetSdkVersion @ANDROID_TARGET_SDK_VERSION@ | ||
| versionCode 301 | ||
| versionName "3.01" |
Contributor
There was a problem hiding this comment.
version
is it correct?
Contributor
There was a problem hiding this comment.
Not sure, but it's the same everywhere. Looks like we need to substitute OpenCV version here and in samples.
Contributor
There was a problem hiding this comment.
Let's do it in a separate PR.
a06589b to
de0aade
Compare
opencv-alalek
approved these changes
Jan 31, 2024
asmorkalov
added a commit
to opencv/ci-gha-workflow
that referenced
this pull request
Jan 31, 2024
Replaces #128 Depends on opencv/opencv#24910 * Added pipeline to test Android configuration with real phone. * Cleanup environment. * Use proper label to select host. * Use proper label to select host. * Set binaries cache location. * Binaries cache path fix. * Removed limitation. * Set git cache location in pipeline.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified Java tests to run on Android.
To run the tests you need to:
cmake -DBUILD_TEST=ON -DANDROID=ON -DANDROID_ABI=arm64-v8a -DCMAKE_TOOLCHAIN_FILE=/usr/lib/android-sdk/ndk/25.1.8937393/build/cmake/android.toolchain.cmake -DANDROID_NDK=/usr/lib/android-sdk/ndk/25.1.8937393 -DANDROID_SDK=/usr/lib/android-sdk ../opencvmakecd android_tests./gradlew tests_module:connectedAndroidTestRelated CI pipeline: opencv/ci-gha-workflow#138
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.