Thanks to visit codestin.com
Credit goes to github.com

Skip to content

ts: Extended getTypeName() to support new types #24992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 12, 2024
Merged

ts: Extended getTypeName() to support new types #24992

merged 1 commit into from
Feb 12, 2024

Conversation

@Kumataro
Copy link
Contributor

@Kumataro Kumataro commented Feb 12, 2024

Extended getTypeName() to support new types.
Close #24991

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@Kumataro Kumataro mentioned this pull request Feb 12, 2024
Closed
6 tasks
@asmorkalov asmorkalov self-requested a review February 12, 2024 09:30
@asmorkalov asmorkalov added this to the 5.0 milestone Feb 12, 2024
@Kumataro
Copy link
Contributor Author

Kumataro commented Feb 12, 2024

In Ubuntu2004-x64-CUDA, dnn test is failed. But I believe it is false-positive.

This result is same as #24980 (comment)

[ RUN      ] DNNTestNetwork.FastNeuralStyle_eccv16/0, where GetParam() = CUDA/CUDA
/home/ci/opencv/modules/dnn/test/test_common.impl.hpp:75: Failure
Expected: (normL1) <= (l1), actual: 0.000712198 vs 0.0007
First run  |ref| = 348.99359130859375
[  FAILED  ] DNNTestNetwork.FastNeuralStyle_eccv16/0, where GetParam() = CUDA/CUDA (296 ms)

asmorkalov
asmorkalov approved these changes Feb 12, 2024
View reviewed changes
Copy link
Contributor

@asmorkalov asmorkalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@asmorkalov asmorkalov merged commit 466ad96 into opencv:5.x Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asmorkalov asmorkalov asmorkalov approved these changes

Assignees

No one assigned

Labels

test

Projects

None yet

Milestone

5.0-alpha

Development

Successfully merging this pull request may close these issues.

2 participants

@Kumataro @asmorkalov