C-API cleanup: apps, imgproc_c and some constants #25075
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Looks good to me! Please fix compiler warnings. 5 cents in addition:
|
Contributor
Author
|
@asmorkalov , alternative to changes in perf tests is modifying opencv_extra: it uses full testcase name as key for sanity check data (https://github.com/opencv/opencv_extra/blob/798ea12f204aab96fe54a5a94c855e1238de0690/testdata/perf/core.xml#L45276). So we need to rename these cases in XML or add new entries with same contents. I thought we tend to remove sanity checks in performance tests and leave this task for accuracy tests. I'll try to backport these changes to 4.x manually in a separate PR. |
c9330b8 to
5294cb3
Compare
* removed apps * removed traincascade tutorial
* removed imgproc_c.h mention from all files * replaced old error constants * replaced some more constants (NORM_, RNG::, PCA::, ...) * replaced CV_ERROR usage with CV_Error
* imgproc/imgproc_c.h * imgproc/types_c.h
5294cb3 to
6b795fd
Compare
asmorkalov
added a commit
to asmorkalov/opencv
that referenced
this pull request
Mar 4, 2024
6 tasks
asmorkalov
added a commit
to asmorkalov/opencv
that referenced
this pull request
Mar 5, 2024
6 tasks
asmorkalov
added a commit
that referenced
this pull request
Mar 5, 2024
Partially back-port #25075 to 4.x
Merged
klatism
pushed a commit
to klatism/opencv
that referenced
this pull request
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge with opencv/opencv_contrib#3642
Most of these changes can be backported to 4.x.