Thanks to visit codestin.com
Credit goes to github.com

Skip to content

3rd party libs upgrade #25085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 9 commits into from
Closed

3rd party libs upgrade #25085

wants to merge 9 commits into from

Conversation

@klatism
Copy link
Contributor

@klatism klatism commented Feb 24, 2024

Pull Request Readiness Checklist

Upgrade a few 3rd party dependencies to improve security:

  1. libjpeg 9d => 9f
  2. libtiff 4.2.0 => 4.6.0
  3. libwebp 1.2.0 => 1.3.2
  4. OpenEXR 2.3.0 => 3.2.2
  5. tbb 2020.2 => 2021.11.0
  6. zlib 1.3.0 => 1.3.1
  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@klatism
Copy link
Contributor Author

klatism commented Feb 24, 2024

I'm looking into warnings in Linux build and Win build failure.

@asmorkalov
Copy link
Contributor

asmorkalov commented Feb 24, 2024

@klatism Thanks a lot for the contribution. Let's do deps update 1 by one with dedicated PRs.

@klatism
Copy link
Contributor Author

klatism commented Feb 25, 2024

@asmorkalov thanks for taking a look! NP, I'll work on splitting this up.

opencv-alalek
opencv-alalek reviewed Feb 25, 2024
View reviewed changes
3rdparty/openexr/CMakeLists.txt
set(OPENEXR_VERSION_MAJOR "2")
set(OPENEXR_VERSION_MINOR "3")
set(OPENEXR_VERSION_PATCH "0")
set(OpenEXR_VERSION_MAJOR "3")
Copy link
Contributor

@opencv-alalek opencv-alalek Feb 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are not going to maintain "own" build of OpenEXR anymore.
Use OpenEXR as external library.

See here:
#21324 (comment)

Copy link
Contributor Author

@klatism klatism Feb 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

got it, thanks!

@klatism
Copy link
Contributor Author

klatism commented Feb 26, 2024

closing this PR: starting separate ones for each dependency:
libjpeg #25092
libtiff #25096
libwebp #25097
tbb #25098

@klatism klatism closed this Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@opencv-alalek opencv-alalek opencv-alalek left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@klatism @asmorkalov @opencv-alalek