Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Partially back-port #25075 to 4.x #25149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 5, 2024
Merged

Partially back-port #25075 to 4.x #25149

merged 1 commit into from
Mar 5, 2024

Conversation

@asmorkalov
Copy link
Contributor

@asmorkalov asmorkalov commented Mar 4, 2024 •
edited
Loading

Related #25075

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@asmorkalov asmorkalov added the cleanup Code cleanup (e.g, drop legacy C-API, legacy unmaintained code) label Mar 4, 2024
@asmorkalov asmorkalov added this to the 4.10.0 milestone Mar 4, 2024
mshabunin
mshabunin reviewed Mar 4, 2024
View reviewed changes
mshabunin
mshabunin approved these changes Mar 4, 2024
View reviewed changes
Copy link
Contributor

@mshabunin mshabunin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me. I thought it might be easier to cherry-pick commits from that PR and then replace what's left.

@asmorkalov
Copy link
Contributor Author

asmorkalov commented Mar 5, 2024

I tried to cherry-pick and found a lot of conflicts and not-touched places. Your PR will be squashed before mere, so there is no much sense to have similar commits.

@asmorkalov asmorkalov force-pushed the as/error_cleanup_backport branch from bb2d9b7 to daa8f7d Compare March 5, 2024 09:15
@asmorkalov asmorkalov merged commit 0f5792a into opencv:4.x Mar 5, 2024
@opencv-alalek opencv-alalek removed their request for review March 5, 2024 12:31
This was referenced Mar 5, 2024
Merged
Closed
@asmorkalov asmorkalov mentioned this pull request Apr 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mshabunin mshabunin mshabunin approved these changes

Assignees

No one assigned

Labels

cleanup Code cleanup (e.g, drop legacy C-API, legacy unmaintained code)

Projects

None yet

Milestone

4.10.0

Development

Successfully merging this pull request may close these issues.

2 participants

@asmorkalov @mshabunin