-
-
Notifications
You must be signed in to change notification settings - Fork 56.4k
Avoid extra memset #25184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid extra memset #25184
Conversation
|
Do we have tests for fp16 convolution? cc @zihaomu |
|
Yes, we have the FP16 accuracy test, which has the flag of opencv/modules/dnn/test/test_onnx_importer.cpp Line 2352 in 52f3f5a
|
It is turned off by default: https://github.com/opencv/opencv/actions/runs/8200307720/job/22436426876?pr=25184#step:17:12821. Tests for a single convolution layer on fp16? |
|
https://github.com/opencv/opencv/actions/runs/8200307720/job/22436426876?pr=25184#step:17:12955, the default is ON, and for some specific cases we turned it off since the accuracy issue was introduced by FP16. |
|
@fengyuentau, @zihaomu, does it make sense to verify that this PR will pass on 5.x branch too? |
|
@dkurt You may create yet another PR to 5.x with the same change. I'll merge it independently. |
Pull Request Readiness Checklist
Just an experiment to avoid extra usage of
memset.See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.