Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@mshabunin
Copy link
Contributor

@mshabunin mshabunin commented Mar 13, 2024

related #25042
Top level headers are h1 in the new documentation, while in old we had h2. I decided to stick language toggle buttons to h1 elements and omit more complex lower-level header matching, because in some tutorials hidden blocks contain headers too, which can cause matching issues.

force_builders_only=docs

@mshabunin
Copy link
Contributor Author

I've reviewed resulting imgproc tutorials: https://pullrequest.opencv.org/buildbot/export/pr/25213/docs/d7/da8/tutorial_table_of_content_imgproc.html
They seem to work fine now, no JS exceptions and all toggle buttons are added to respective H1 headers.

@asmorkalov asmorkalov added the category: documentation Documentation fix or update label Mar 23, 2024
@asmorkalov asmorkalov self-requested a review March 23, 2024 10:47
@asmorkalov asmorkalov added this to the 4.10.0 milestone Mar 25, 2024
Copy link
Contributor

@asmorkalov asmorkalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@asmorkalov asmorkalov merged commit bf2626e into opencv:4.x Mar 25, 2024
@asmorkalov asmorkalov self-assigned this Mar 25, 2024
@mshabunin mshabunin deleted the fix-doc-buttons branch March 25, 2024 08:00
@asmorkalov asmorkalov mentioned this pull request Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category: documentation Documentation fix or update

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants