Add cv::currentUIFramework #25354
Merged
Add cv::currentUIFramework #25354
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@opencv-alalek |
modules/highgui/src/backend.hpp
Outdated
|
|
||
| virtual int waitKeyEx(int delay /*= 0*/) = 0; | ||
| virtual int pollKey() = 0; | ||
| virtual std::string currentUIFramework() = 0; |
Contributor
There was a problem hiding this comment.
virtual const std::string getName() const = 0;
modules/highgui/src/window.cpp
Outdated
| { | ||
| return backend->currentUIFramework(); | ||
| } | ||
| return ""; |
Contributor
There was a problem hiding this comment.
return std::string(); instead of ""
Anyway where should be large #if switch for COCOA / QT and others "builtin" backends.
Check cv::setWindowTitle implementation as reference.
|
|
||
| std::string currentUIFramework() | ||
| { | ||
| return "WIN32"; |
Contributor
There was a problem hiding this comment.
should be implemented for GTK2/3 too.
| */ | ||
| CV_EXPORTS_W void destroyAllWindows(); | ||
|
|
||
| CV_EXPORTS_W std::string currentUIFramework(); |
Contributor
Author
|
Finally I wonder why not used getBuildInformation output to create a dictionnary? |
| CV_Error(Error::StsNotImplemented, "The function is not implemented with this GUI. "); | ||
| return std::string(); | ||
| #elif defined(HAVE_WIN32UI) | ||
| auto backend = getCurrentUIBackend(); |
Contributor
There was a problem hiding this comment.
What is the problem with scheme similar to setWindowTitle?
Only one branch should try "plugin" interface. Other are builtins and they are pre-defined constants.
Contributor
Author
There was a problem hiding this comment.
I hope I understang plugins well
Contributor
|
Added test, fixes, and rebased on 4.x branch. |
opencv-alalek
approved these changes
Apr 19, 2024
Merged
klatism
pushed a commit
to klatism/opencv
that referenced
this pull request
May 17, 2024
Add cv::currentUIFramework opencv#25354 issue opencv#25329 ### Pull Request Readiness Checklist See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request - [x] I agree to contribute to the project under Apache 2 License. - [x] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV - [ ] The PR is proposed to the proper branch - [x] There is a reference to the original bug report and related work - [ ] There is accuracy test, performance test and test data in opencv_extra repository, if applicable Patch to opencv_extra has the same branch name. - [x] The feature is well documented and sample code can be built with the project CMake
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Readiness Checklist
issue #25329
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.