Add videocapture_depth.cpp sample #25410
Conversation
|
There is an older example orbbec_astra.cpp in the tutorial_code folder which demonstrates how to use the OpenNI based Orbbec cameras with OpenCV. These cameras are already discontinued and newer Orbbec cameras are all using the UVC protocols. Should we remove the older sample? @vpisarev |
|
@kaingwade Thanks a lot for the contribution. Please take https://docs.opencv.org/4.x/d4/d65/tutorial_orbbec_astra.html in account too. |
|
|
asmorkalov
left a comment
There was a problem hiding this comment.
The new sample looks like just mix of 4 original pieces. Almost no unification.
I propose the following:
- Presume original
orbbec_astra.cppas it uses 2 VideoCapture instances and manual threading/synchronization. I propose to rename it to something line openni_orbbec_astra.cpp and mention that there is is alternative SDK in the sample description. - Unify other 3 branches to use the same loop.
- Backport Orbbec OpenNI related changes in documentation to 4.x to fix it too.
Update the tutorial of using Orbbec Astra cameras #25813 This PR is the backport of Orbbec OpenNI-based Astra camera related changes from #25410 to the 4.x branch, which includes updating the tutorial of Orbbec Astra cameras, renaming `orbbec_astra.cpp`. ### Pull Request Readiness Checklist See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request - [x] I agree to contribute to the project under Apache 2 License. - [x] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV - [x] The PR is proposed to the proper branch - [ ] There is a reference to the original bug report and related work - [ ] There is accuracy test, performance test and test data in opencv_extra repository, if applicable Patch to opencv_extra has the same branch name. - [x] The feature is well documented and sample code can be built with the project CMake
|
@kaingwade I merged your patch to 4.x and it was promoted to 5.x in #25840. You need to rebase and solve the conflicts. |
Done. |
|
asmorkalov
left a comment
There was a problem hiding this comment.
Looks good to me, besides minor comments. Could you add list of tested cameras to the PR description? It'll be useful for issues triaging.
The PR is to combine the examples
videocapture_openni.cpp,videocapture_realsense.cppandvideocapture_obsensor.cppintovideocapture_depth.cpp.Tested cameras and OS using this sample are listed below:
Note: