Fix race condition in InternalFFMpegRegister initialization. #25419
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if(!threadSafe) | ||
| lock.lock(); | ||
| static InternalFFMpegRegister instance; | ||
| initLogger_(); // update logger setup unconditionally (GStreamer's libav plugin may override these settings) |
Contributor
There was a problem hiding this comment.
I take a look on the comment.
It comes from this commit: 7baf2e8
which commit message says "repair FFmpeg logger settings on each .open() call"
@mshabunin Do you remember which reproducer we had for this case?
Contributor
There was a problem hiding this comment.
@mshabunin Do you remember which reproducer we had for this case?
No, I don't 🙁
PR was #19661
Contributor
Author
|
FYI, the stack trace we have is (line numbers might be off by a few units; if needed I can get the exact code references): |
opencv-alalek
approved these changes
Apr 16, 2024
initLogger_ does not check if the logger has been initizalized before and it might initialize it several times from different threads, racing with other threads that are logging.
Merged
klatism
pushed a commit
to klatism/opencv
that referenced
this pull request
May 17, 2024
Fix race condition in InternalFFMpegRegister initialization. opencv#25419 initLogger_ does not check if the logger has been initizalized before and it might initialize it several times from different threads, racing with other threads that are logging. ### Pull Request Readiness Checklist See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request - [x] I agree to contribute to the project under Apache 2 License. - [x] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV - [x] The PR is proposed to the proper branch - [x] There is a reference to the original bug report and related work
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
initLogger_ does not check if the logger has been initizalized before and it might initialize it several times from different threads, racing with other threads that are logging.
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request