-
-
Notifications
You must be signed in to change notification settings - Fork 56.4k
change fcn8s-heavy-pascal tests from caffe to onnx #25435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
CI failed because of the lack of new model. |
dkurt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR should target 4.x branch
Done. |
asmorkalov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
|
Failed test: |
| std::string inp = _tf("dog416.png"); | ||
| std::string weights_file = _tf("fcn8s-heavy-pascal.prototxt"); | ||
| std::string config_file = _tf("fcn8s-heavy-pascal.caffemodel", false); | ||
| std::string weights_file = _tf("onnx/models/fcn-resnet50-12.onnx"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be optional?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, second argument should be false.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in #25538
Merged with: opencv/opencv_extra#1171
Part of #25314
This PR aims to change the tests related to fcn8s-heavy-pascal from caffe framework to onnx. The new fcn models have different backbone and output.
new model link: https://github.com/onnx/models/blob/main/validated/vision/object_detection_segmentation/fcn/model/fcn-resnet50-12.onnx
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.