Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@WanliZhong
Copy link
Member

Merged with: opencv/opencv_extra#1171
Part of #25314

This PR aims to change the tests related to fcn8s-heavy-pascal from caffe framework to onnx. The new fcn models have different backbone and output.

new model link: https://github.com/onnx/models/blob/main/validated/vision/object_detection_segmentation/fcn/model/fcn-resnet50-12.onnx

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@WanliZhong WanliZhong added this to the 5.0 milestone Apr 17, 2024
@WanliZhong WanliZhong requested a review from asmorkalov April 18, 2024 10:46
@WanliZhong WanliZhong added the cleanup Code cleanup (e.g, drop legacy C-API, legacy unmaintained code) label Apr 18, 2024
@WanliZhong
Copy link
Member Author

CI failed because of the lack of new model.

@asmorkalov asmorkalov requested a review from vpisarev April 19, 2024 12:56
@asmorkalov asmorkalov added the RFC label Apr 24, 2024
@dkurt dkurt self-requested a review April 26, 2024 06:58
Copy link
Member

@dkurt dkurt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR should target 4.x branch

@asmorkalov asmorkalov added the pr: needs rebase Rebase patch (and squash fixup commits) on the top of target branch label May 2, 2024
@WanliZhong WanliZhong changed the base branch from 5.x to 4.x May 2, 2024 16:15
@WanliZhong WanliZhong removed the pr: needs rebase Rebase patch (and squash fixup commits) on the top of target branch label May 2, 2024
@WanliZhong
Copy link
Member Author

PR should target 4.x branch

Done.

@asmorkalov asmorkalov modified the milestones: 5.0, 4.10.0 May 3, 2024
Copy link
Contributor

@asmorkalov asmorkalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dkurt
Copy link
Member

dkurt commented May 3, 2024

Failed test:

[  FAILED  ] Test_Model.Segmentation/0, where GetParam() = OCV/CPU

std::string inp = _tf("dog416.png");
std::string weights_file = _tf("fcn8s-heavy-pascal.prototxt");
std::string config_file = _tf("fcn8s-heavy-pascal.caffemodel", false);
std::string weights_file = _tf("onnx/models/fcn-resnet50-12.onnx");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be optional?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, second argument should be false.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in #25538

@asmorkalov asmorkalov merged commit c539cfd into opencv:4.x May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category: dnn (onnx) ONNX suport issues in DNN module category: dnn cleanup Code cleanup (e.g, drop legacy C-API, legacy unmaintained code) OpenCV5 RFC test

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants