Integrate ARM KleidiCV as OpenCV HAL #25443
Conversation
a98fb17 to
e37f7d6
Compare
|
@opencv-alalek @mplatings I re-integrated KleidiCV with |
|
Thanks Alexander. Can you try with this newer KleidiCV version please: https://gitlab.arm.com/kleidi/kleidicv/-/archive/a9971ba8bf1d8b008a32c6ed8fea05cd8eb16748/kleidicv-a9971ba8bf1d8b008a32c6ed8fea05cd8eb16748.tar.gz |
|
Fixed review remarks. Works on HAL priorities. |
|
@opencv-alalek I introduced commit hash as parameter for KleidiCV download as you proposed. |
That is not true. CMake scrips do that by defining order of used HAL headers. The last header has the highest priority because it is used like this (example from carotene): Any previous definitions from other HALs are undefined unconditionally. |
|
Current CMake adds HAL implementation at the beginning of the list. With the CMake chain KleidiCV -> Carotene we have list "carotene;kleidicv". The last one is Kleidi and it defines macros with fallback to previous implementation, Carotene. So current version works as expected. |
Integrate ARM KleidiCV as OpenCV HAL opencv#25443 The library source code with license: https://gitlab.arm.com/kleidi/kleidicv/ ### Pull Request Readiness Checklist See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request - [x] I agree to contribute to the project under Apache 2 License. - [x] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV - [x] The PR is proposed to the proper branch - [x] There is a reference to the original bug report and related work - [ ] There is accuracy test, performance test and test data in opencv_extra repository, if applicable Patch to opencv_extra has the same branch name. - [ ] The feature is well documented and sample code can be built with the project CMake
KleidiCV HAL update to version 0.1.0. #25618 Original integration PR: #25443 Force the library for testing with CI ### Pull Request Readiness Checklist See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request - [x] I agree to contribute to the project under Apache 2 License. - [x] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV - [x] The PR is proposed to the proper branch - [x] There is a reference to the original bug report and related work - [ ] There is accuracy test, performance test and test data in opencv_extra repository, if applicable Patch to opencv_extra has the same branch name. - [ ] The feature is well documented and sample code can be built with the project CMake
The library source code with license: https://gitlab.arm.com/kleidi/kleidicv/
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.