Perf tests for SVD and solve() created #25450
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@vpisarev @opencv-alalek Could you take a look current state? The performance test makes iterations on different input for solve/SVD, but not the same parameters each time. Is it allowed behaviour of the test? Each iteration of performance test has different behaviour internally and the test may not converge in sense of statistics distribution. |
asmorkalov
reviewed
Apr 22, 2024
asmorkalov
reviewed
Apr 24, 2024
asmorkalov
reviewed
Apr 24, 2024
vpisarev
reviewed
Apr 25, 2024
| } | ||
|
|
||
| // generates random vectors, performs Gram-Schmidt orthogonalization on them | ||
| Mat randomOrtho(int rows, int ftype, RNG& rng) |
Contributor
There was a problem hiding this comment.
Gram-Schmidt is known to produce huge rounding errors. Use QR decomposition instead and remove the 'R' part.
Contributor
Author
There was a problem hiding this comment.
- We don't need exact orhogonalization, just some random orthogonal matrix
- I've checked its orthogonality (
A^T*A-Ias well asA*A^T-I) and its in acceptable epsilon bounds - The only QR decomposition we have is in
cv::halnamespace, I'm not sure whether it's OK to use it in test even if it's exposed to public API
asmorkalov
approved these changes
Apr 27, 2024
klatism
pushed a commit
to klatism/opencv
that referenced
this pull request
May 17, 2024
Perf tests for SVD and solve() created opencv#25450 fixes opencv#25336 ### Pull Request Readiness Checklist See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request - [x] I agree to contribute to the project under Apache 2 License. - [x] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV - [x] The PR is proposed to the proper branch - [x] There is a reference to the original bug report and related work - [x] There is accuracy test, performance test and test data in opencv_extra repository, if applicable Patch to opencv_extra has the same branch name. - [x] The feature is well documented and sample code can be built with the project CMake
Merged
savuor
added a commit
to savuor/opencv
that referenced
this pull request
Nov 5, 2024
Perf tests for SVD and solve() created opencv#25450 fixes opencv#25336 ### Pull Request Readiness Checklist See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request - [x] I agree to contribute to the project under Apache 2 License. - [x] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV - [x] The PR is proposed to the proper branch - [x] There is a reference to the original bug report and related work - [x] There is accuracy test, performance test and test data in opencv_extra repository, if applicable Patch to opencv_extra has the same branch name. - [x] The feature is well documented and sample code can be built with the project CMake
savuor
added a commit
to savuor/opencv
that referenced
this pull request
Nov 8, 2024
Perf tests for SVD and solve() created opencv#25450 fixes opencv#25336 ### Pull Request Readiness Checklist See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request - [x] I agree to contribute to the project under Apache 2 License. - [x] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV - [x] The PR is proposed to the proper branch - [x] There is a reference to the original bug report and related work - [x] There is accuracy test, performance test and test data in opencv_extra repository, if applicable Patch to opencv_extra has the same branch name. - [x] The feature is well documented and sample code can be built with the project CMake
savuor
added a commit
to savuor/opencv
that referenced
this pull request
Nov 21, 2024
Perf tests for SVD and solve() created opencv#25450 fixes opencv#25336 ### Pull Request Readiness Checklist See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request - [x] I agree to contribute to the project under Apache 2 License. - [x] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV - [x] The PR is proposed to the proper branch - [x] There is a reference to the original bug report and related work - [x] There is accuracy test, performance test and test data in opencv_extra repository, if applicable Patch to opencv_extra has the same branch name. - [x] The feature is well documented and sample code can be built with the project CMake
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #25336
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.