Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix statckblur big kernel case #25513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 1, 2024
Merged

fix statckblur big kernel case #25513

merged 1 commit into from
May 1, 2024

Conversation

@zihaomu
Copy link
Member

@zihaomu zihaomu commented Apr 30, 2024 •
edited by asmorkalov
Loading

fix the issue: #25498

kernelSize = radius*2 + 1. If the kernel size is bigger then width, we need to set a bigger buffer for it.

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@zihaomu zihaomu linked an issue Apr 30, 2024 that may be closed by this pull request
stackBlur caused the program to crash #25498
Closed
4 tasks
@zihaomu zihaomu added the bug label Apr 30, 2024
zihaomu
zihaomu commented Apr 30, 2024
View reviewed changes
modules/imgproc/src/stackblur.cpp
else
{
size_t bufSize = CN * (width + radius) * sizeof(TBuf) + 2 * CN * sizeof(TBuf);
size_t bufSize = CN * (width + kernelSize) * sizeof(TBuf) + 2 * CN * sizeof(TBuf);
Copy link
Member Author

@zihaomu zihaomu Apr 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kernelSize = radius*2 +1, if the kernel size is bigger then width, we need to set a bigger buffer for it.

@asmorkalov asmorkalov added this to the 4.10.0 milestone Apr 30, 2024
@asmorkalov asmorkalov self-requested a review April 30, 2024 08:31
@asmorkalov asmorkalov self-assigned this Apr 30, 2024
asmorkalov
asmorkalov reviewed Apr 30, 2024
View reviewed changes
@asmorkalov asmorkalov merged commit 1f6f092 into opencv:4.x May 1, 2024
@mshabunin mshabunin mentioned this pull request Jun 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asmorkalov asmorkalov asmorkalov approved these changes

Assignees

@asmorkalov asmorkalov

Labels

bug category: imgproc

Projects

None yet

Milestone

4.10.0

Development

Successfully merging this pull request may close these issues.

stackBlur caused the program to crash

2 participants

@zihaomu @asmorkalov