Thanks to visit codestin.com
Credit goes to github.com

Skip to content

YUV codes for cvtColor: descriptions added #25616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
May 25, 2024
Merged

YUV codes for cvtColor: descriptions added #25616

merged 9 commits into from
May 25, 2024

Conversation

@savuor
Copy link
Contributor

@savuor savuor commented May 22, 2024

This PR contains descriptions for various RGB <-> YUV color conversion codes as well as detailed comments in the source code.

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@asmorkalov asmorkalov added the category: documentation Documentation fix or update label May 22, 2024
@asmorkalov asmorkalov added this to the 4.10.0 milestone May 22, 2024
mshabunin
mshabunin reviewed May 22, 2024
View reviewed changes
asmorkalov
asmorkalov reviewed May 23, 2024
View reviewed changes
modules/imgproc/include/opencv2/imgproc.hpp

COLOR_YUV2GRAY_UYVY = 123, //!< extract channel from YUV 4:2:2 image
COLOR_YUV2GRAY_YUY2 = 124, //!< extract channel from YUV 4:2:2 image
//CV_YUV2GRAY_VYUY = CV_YUV2GRAY_UYVY, //!< synonym to COLOR_YUV2GRAY_UYVY
Copy link
Contributor

@asmorkalov asmorkalov May 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is it commented?

Copy link
Contributor Author

@savuor savuor May 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No idea, tracks lead to the original code from 2012. Maybe it didn't work properly then.
If we want to enable it back, we need a separate PR.

asmorkalov
asmorkalov approved these changes May 23, 2024
View reviewed changes
Copy link
Contributor

@asmorkalov asmorkalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@opencv-alalek opencv-alalek removed their request for review May 23, 2024 17:05
@mshabunin mshabunin mentioned this pull request May 24, 2024
Merged
6 tasks
@asmorkalov asmorkalov self-assigned this May 25, 2024
@asmorkalov asmorkalov merged commit 1fa96b1 into opencv:4.x May 25, 2024
@savuor savuor deleted the rv/yuv_docs branch May 26, 2024 21:58
@mshabunin mshabunin mentioned this pull request Jun 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mshabunin mshabunin mshabunin left review comments

@asmorkalov asmorkalov asmorkalov approved these changes

Assignees

@asmorkalov asmorkalov

Labels

category: documentation Documentation fix or update

Projects

None yet

Milestone

4.10.0

Development

Successfully merging this pull request may close these issues.

3 participants

@savuor @asmorkalov @mshabunin