Highgui backend on top of Framebuffer #25661
Conversation
mshabunin
left a comment
There was a problem hiding this comment.
Thank you! Overall looks good to me, two comments should be fixed before merge.
Perhaps we could improve the code a little bit, but it's not critical. Let's observe the community feedback and act accordingly.
|
@opencv-alalek could you take a look again? |
opencv-alalek
left a comment
There was a problem hiding this comment.
Thank you for update!
|
@opencv-alalek Did I understand correctly what changes needed to be made to the CMake files? |
|
@opencv-alalek Is the WITH_FRAMEBUFFER_XVFB option redundant? I can remove the option and fix the warning issued in the main implementation (window_framebuffer.cpp) |
|
@kozinove , if(WITH_FRAMEBUFFER)
# ...
if(WITH_FRAMBUFFER_XVFB)
# ... check header files and enable feature if they exist
endif()
# ...
endif() |
|
fixed work with framebuffer in cmake
|
mshabunin
left a comment
There was a problem hiding this comment.
Thank you! Looks good to me. Just several minor comments.
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.
Environment variables used:
OPENCV_UI_BACKEND - you need to add the value “FB”
OPENCV_UI_PRIORITY_FB - requires priority indication
OPENCV_HIGHGUI_FB_MODE={FB|XVFB|EMU} - mode of using Framebuffer (default "FB")
OPENCV_HIGHGUI_FB_DEVICE (FRAMEBUFFER) - path to the Framebuffer file (default "/dev/fb0").
Examples of using:
sudo OPENCV_UI_BACKEND=FB ./opencv_test_highgui
sudo OPENCV_UI_PRIORITY_FB=1111 ./opencv_test_highgui
OPENCV_UI_BACKEND=FB OPENCV_HIGHGUI_FB_MODE=EMU ./opencv_test_highgui
sudo OPENCV_UI_BACKEND=FB OPENCV_HIGHGUI_FB_MODE=FB ./opencv_test_highgui
export DISPLAY=:99
Xvfb $DISPLAY -screen 0 1024x768x24 -fbdir /tmp/ -f /tmp/user.xvfb.auth&
sudo -u sipeed XAUTHORITY=/tmp/user.xvfb.auth x11vnc -display $DISPLAY -listen localhost&
DISPLAY=:0 gvncviewer localhost&
FRAMEBUFFER=/tmp/Xvfb_screen0 OPENCV_UI_BACKEND=FB OPENCV_HIGHGUI_FB_MODE=XVFB ./opencv_test_highgui