Tests added for mixed type arithmetic operations #25671
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 30, 2024 00:16
asmorkalov
reviewed
Jun 1, 2024
modules/core/test/test_arithm.cpp
Outdated
| } | ||
| double getMaxErr(int depth) | ||
| { | ||
| return depth <= CV_32S ? 2 : depth < CV_64F ? 1e-5 : 1e-12; |
Contributor
Author
There was a problem hiding this comment.
Actually, this part of code wasn't actually changed, it's inherited from previous commit
It's 2 everywhere where multiplication/division is performed
It can be safely dropped to 1 at least on my machine (will check it on CI)
I guess this threshold was tuned to actual accuracy level sometime in the past
asmorkalov
approved these changes
Jun 2, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Note: div-by-zero values are removed from checking since the result is implementation-defined in common case
getMulExtTab()function that lead to dead codePull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.