Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fixed offset computation for ND case in MinMaxIdx HAL. #25679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 31, 2024
Merged

Fixed offset computation for ND case in MinMaxIdx HAL. #25679

merged 1 commit into from
May 31, 2024

Conversation

@asmorkalov
Copy link
Contributor

@asmorkalov asmorkalov commented May 31, 2024 •
edited
Loading

Fixes bug found in discussion #25563
Alternative to #25669

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@asmorkalov asmorkalov added this to the 4.10.0 milestone May 31, 2024
@asmorkalov
Copy link
Contributor Author

asmorkalov commented May 31, 2024

cc @mplatings

@asmorkalov asmorkalov merged commit f4ebf7c into opencv:4.x May 31, 2024
savuor
savuor reviewed May 31, 2024
View reviewed changes
modules/core/src/minmax.cpp
ofs2idx(src, minIdx[1], minIdx);
if (maxIdx)
ofs2idx(src, maxIdx[0], maxIdx);
ofs2idx(src, maxIdx[1], maxIdx);
Copy link
Contributor

@savuor savuor May 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minIdx[1] and maxIdx[1] returned by HAL function should be shifted by 1
It's not described anywhere, let's fix this by #25669

Copy link
Contributor Author

@asmorkalov asmorkalov Jun 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why?

@mshabunin mshabunin mentioned this pull request Jun 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@savuor savuor savuor left review comments

@vpisarev vpisarev vpisarev approved these changes

@opencv-alalek opencv-alalek opencv-alalek approved these changes

+1 more reviewer

@mplatings mplatings mplatings approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@vpisarev vpisarev

Labels

bug category: core

Projects

OpenCV 4.x HAL improvement
Status: Done

Milestone

4.10.0

Development

Successfully merging this pull request may close these issues.

5 participants

@asmorkalov @mplatings @vpisarev @savuor @opencv-alalek