Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@fengyuentau
Copy link
Member

Previous #24804 #25625
Fixes #25675 (comment)
Closes #25675

When I was testing the two previous PRs, I only built opencv_test_core so the other places where OCV_LAPACK_FUNC is called is missed. I built the whole library this time with

cmake -B build -DCMAKE_BUILD_TYPE=Release -DCMAKE_EXPORT_COMPILE_COMMANDS=ON -DBUILD_ZLIB=OFF -DCMAKE_INSTALL_PREFIX=build/install .
cmake --build build --target install -j4

and no errors occur. So it should be fine now.

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@fengyuentau
Copy link
Member Author

Lets see whether ci checks pass or not.

cc @thewoz

Copy link
Contributor

@asmorkalov asmorkalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@asmorkalov asmorkalov merged commit 0810795 into opencv:4.x May 31, 2024
@asmorkalov asmorkalov self-assigned this May 31, 2024
@fengyuentau fengyuentau deleted the calib3d/lapack_fix_calib3d branch May 31, 2024 18:13
@mshabunin mshabunin mentioned this pull request Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

macOs error: no matching function for call to 'dgeev_'

2 participants