Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@VadimLevin
Copy link
Contributor

closes #25714

Resulting cv2/__init__.pyi entries:

@_typing.overload
def floodFill(
    image: cv2.typing.MatLike,
    mask: cv2.typing.MatLike | None,
    seedPoint: cv2.typing.Point,
    newVal: cv2.typing.Scalar,
    loDiff: cv2.typing.Scalar = ...,
    upDiff: cv2.typing.Scalar = ...,
    flags: int = ...
) -> tuple[int, cv2.typing.MatLike, cv2.typing.MatLike, cv2.typing.Rect]: ...

@_typing.overload
def floodFill(
    image: UMat,
    mask: UMat | None,
    seedPoint: cv2.typing.Point,
    newVal: cv2.typing.Scalar,
    loDiff: cv2.typing.Scalar = ...,
    upDiff: cv2.typing.Scalar = ...,
    flags: int = ...
) -> tuple[int, UMat, UMat, cv2.typing.Rect]: ...

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@VadimLevin VadimLevin added this to the 4.11.0 milestone Jun 6, 2024
@VadimLevin VadimLevin self-assigned this Jun 6, 2024
@VadimLevin VadimLevin requested a review from asmorkalov June 6, 2024 08:56
@asmorkalov asmorkalov merged commit cbf3b11 into opencv:4.x Jun 6, 2024
@johnthagen
Copy link

@VadimLevin Thank you for this fix!

@mshabunin mshabunin mentioned this pull request Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

floodFill mask argument is missing | None part of type signature

3 participants