Thanks to visit codestin.com
Credit goes to github.com

Skip to content

video: fix vittrack in the case where crop size grows until out-of-memory when the input is black #25771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 18, 2024
Merged

video: fix vittrack in the case where crop size grows until out-of-memory when the input is black #25771

merged 4 commits into from
Jun 18, 2024

Conversation

@fengyuentau
Copy link
Member

@fengyuentau fengyuentau commented Jun 17, 2024

Fixes #25760

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@fengyuentau fengyuentau added this to the 4.11.0 milestone Jun 17, 2024
@fengyuentau fengyuentau requested review from asmorkalov and dkurt June 17, 2024 07:33
asmorkalov
asmorkalov reviewed Jun 17, 2024
View reviewed changes
@asmorkalov
Copy link
Contributor

asmorkalov commented Jun 17, 2024 

C:\build\precommit_windows64\4.x\opencv\modules\video\src\tracking\tracker_vit.cpp(106): warning C4244: 'initializing': conversion from 'double' to 'float', possible loss of data [C:\build\precommit_windows64\build\modules\video\opencv_video.vcxproj]
C:\build\precommit_windows64\4.x\opencv\modules\video\src\tracking\tracker_vit.cpp(107): warning C4244: 'initializing': conversion from 'double' to 'float', possible loss of data [C:\build\precommit_windows64\build\modules\video\opencv_video.vcxproj]

asmorkalov
asmorkalov approved these changes Jun 18, 2024
View reviewed changes
Copy link
Contributor

@asmorkalov asmorkalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@asmorkalov
Copy link
Contributor

asmorkalov commented Jun 18, 2024 

 [----------] 1 test from vittrack
[ RUN      ] vittrack.accuracy_vittrack
Unmatched IOU:  expect IOU val (0.642462) > the IOU threadhold (0.65)! Box 0 is [58 x 108 from (329, 88)], and Box 1 is [78 x 125 from (311, 83)]
/home/ci/opencv/modules/video/test/test_trackers.cpp:110: Failure
Value of: checkIOU(roi, targetRois[i], iouThreshold)
  Actual: false
Expected: true
Fail at img 4.
[  FAILED  ] vittrack.accuracy_vittrack (95 ms)

@asmorkalov asmorkalov self-requested a review June 18, 2024 07:15
asmorkalov
asmorkalov approved these changes Jun 18, 2024
View reviewed changes
Copy link
Contributor

@asmorkalov asmorkalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@asmorkalov
Copy link
Contributor

asmorkalov commented Jun 18, 2024

Tested manually with Ubuntu 20.04.

@asmorkalov asmorkalov merged commit e3884a9 into opencv:4.x Jun 18, 2024
@asmorkalov asmorkalov self-assigned this Jun 18, 2024
@fengyuentau fengyuentau deleted the vittrack_black_input branch June 19, 2024 05:21
@asmorkalov asmorkalov mentioned this pull request Jul 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asmorkalov asmorkalov asmorkalov approved these changes

@dkurt dkurt Awaiting requested review from dkurt

Assignees

@asmorkalov asmorkalov

Labels

bug category: video

Projects

None yet

Milestone

4.11.0

Development

Successfully merging this pull request may close these issues.

dnn/video: TrackerVit crashes when target is lost

2 participants

@fengyuentau @asmorkalov