Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@richard28039
Copy link
Contributor

@richard28039 richard28039 commented Jun 17, 2024

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

Hello, I noticed that the /samples/dnn/models.yml said it should be used for all yolov8 models, but the YOLOv8l is not included in the file, so I added it to the file, thanks.
image

@asmorkalov
Copy link
Contributor

We already have several yolov8 models in samples. We do not need yet another one, if it just brings fatter backbone, but not some DNN features.

@Tsai-chia-hsiang
Copy link
Contributor

But we think the model.yml file.

# Might be used for all YOLOv8n YOLOv8s YOLOv8m YOLOv8l and YOLOv8x

It says that it supports the YOLOv8L model, but there is no link for the YOLOv8L model.
Thus, it's better to support YOLOv8L to satisfy what Line 22 says.

Thanks!

@asmorkalov asmorkalov self-assigned this Jun 21, 2024
@asmorkalov asmorkalov added this to the 4.11.0 milestone Jun 21, 2024
@asmorkalov
Copy link
Contributor

Looks like the model was exported with another parameters than all other yolos we have in the sample. The sample generate a lot of garbage boxes that do not correspond to real objects. Command for the sample: ./bin/example_dnn_yolo_detector --model=./yolov8l.onnx --yolo=yolov8

@richard28039
Copy link
Contributor Author

richard28039 commented Jun 21, 2024

Hi, the models.yml scale is 0.0039, and it's necessary to give this argument.

If not passing --scale = 0.0039:

./yolo_detecor --input=./261902.jpg --yolo=yolov8 --model=./yolov8l.onnx 

The result of yolo_detecor.cpp is

testyolov8l_no_scale

After passing --scale = 0.0039

./yolo_detecor --input=./261902.jpg --yolo=yolov8 --model=./yolov8l.onnx  --scale=0.0039 

The result becomes:

testyolov8l_with_scale

Please take a look, Thanks!

@richard28039
Copy link
Contributor Author

Hello, I found some mistakes when testing, so I removed the unnecessary whitespace in line92 and pushed the new commit; thanks.

Samples/dnn/models.yml:92: trailing whitespace.

@asmorkalov asmorkalov merged commit 11c69bb into opencv:4.x Jun 24, 2024
@asmorkalov asmorkalov mentioned this pull request Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants