Fix #25833: The correct way to disable top-most state is with HWND_NOTOPMOST, not HWND_TOP. #25836
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…WND_NOTOPMOST, not HWND_TOP.
asmorkalov
approved these changes
Jul 1, 2024
Contributor
|
It's hard to check the window position top/not-top in cross-platform way. The unit test will be too complex here. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #25833
Would it make sense to add a test case for this? It would be a pair of
setWindowProperty/getWindowPropertyto verify thatWND_PROP_TOPMOSTactually changes (one symptom of the bug). Unfortunately I can't seem to get the tests to even appear in the generated VS solution right now...