Fix file descriptor leak in HDR decoder #25838
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch to opencv_extra has the same branch name.
For invalid input data there is an exception here:
opencv/modules/imgcodecs/src/grfmt_hdr.cpp
Line 79 in bbf65a1
which leads to missing
fclosecall. It's possible to wrapRGBE_ReadHeaderwith try-catch and callfclosein place, but I chose a more reliable way. Please let me know if another way is preferred for the fix.The issue was found during the oss-fuzz testing.
Test sample:
01ba0766ae85fb245abfb4e94ee828c98c772135