Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@vrabaud
Copy link
Contributor

@vrabaud vrabaud commented Jul 11, 2024

This fixes #25065

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

Copy link

@Quuxplusone Quuxplusone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me, FWIW. :)

@asmorkalov
Copy link
Contributor

@vrabaud @opencv-alalek @vpisarev I added cv::terminate and CV_AssertTerminate for the case. Please take a look on the solution.

@asmorkalov asmorkalov added this to the 4.11.0 milestone Jul 12, 2024
@asmorkalov asmorkalov merged commit 3ff97c5 into opencv:4.x Jul 12, 2024
@asmorkalov asmorkalov mentioned this pull request Jul 16, 2024
fengyuentau pushed a commit to fengyuentau/opencv that referenced this pull request Aug 15, 2024
Mark cv::Mat(Mat&&) as noexcept opencv#25899

This fixes opencv#25065

### Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

- [x] I agree to contribute to the project under Apache 2 License.
- [x] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
- [x] The PR is proposed to the proper branch
- [x] There is a reference to the original bug report and related work
- [ ] There is accuracy test, performance test and test data in opencv_extra repository, if applicable
      Patch to opencv_extra has the same branch name.
- [ ] The feature is well documented and sample code can be built with the project CMake
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Could cv::Mat be nothrow movable?

4 participants